Skip to content

Clarified not to delete or disable a previous TDE protector key after a rotation. #10119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sanjayd
Copy link

@sanjayd sanjayd commented Jun 20, 2025

A user I was supporting in the past disabled their previous TDE Protector key in keyvault after rotating it. This caused their database to become unavailable following the rotation. Earlier in the doc it is advised that old backups and log files may still require access to the old key and to keep it active until sys.dm_db_log_info shows it's no longer in use, but this !important text box only mentions not to delete it. Adding a clarification to keep it active would help avoid similar situations.

Copy link
Contributor

@sanjayd : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 2c1f17e:

✅ Validation status: passed

File Status Preview URL Details
azure-sql/database/transparent-data-encryption-byok-key-rotation.md ✅Succeeded

For more details, please refer to the build report.

@v-regandowner
Copy link
Contributor

@Pietervanhove - Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jun 20, 2025
@VanMSFT
Copy link
Member

VanMSFT commented Jun 24, 2025

Hi @sanjayd! Thanks for submitting this change. We appreciate the feedback. However, keeping the key around is already implied in the article, and it should follow that the previous key is used to access the previous protected data. I don't think the extra verbiage is necessary. I will close this for now, but we'll be happy to accept more feedback.

#assign:VanMSFT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants